Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Cypress CI components #1386

Merged
merged 14 commits into from
Dec 15, 2022
Merged

Update Cypress CI components #1386

merged 14 commits into from
Dec 15, 2022

Conversation

mojotalantikite
Copy link
Contributor

@mojotalantikite mojotalantikite commented Dec 15, 2022 •
edited
Loading

Summary

Cypress was having issues with GPU in Linux on our containers, and this PR does a few things:

  • Upgrades the Cypress container for a newer Chrome
  • Pins the Linux version we run in
  • Is explicit about testing-library versions
  • Matches the chromedriver between local and CI
  • Sets an autogenerated build ID for Cypress runs, which is recommended by Cypress for matrix runs in CI. This should fix the issues we've been seeing in promote where the Cypress run has already been marked as complete.

Related issues

https://qmacbis.atlassian.net/browse/MR-2897

@github-actions github-actions bot temporarily deployed to review-apps December 15, 2022 18:11 Inactive
@github-actions github-actions bot temporarily deployed to review-apps December 15, 2022 18:29 Inactive
macrael
macrael approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@macrael macrael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whack each mole

haworku
haworku approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@haworku haworku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the PR description, that helped.

@mojotalantikite mojotalantikite merged commit 10f745b into main Dec 15, 2022
@mojotalantikite mojotalantikite deleted the mt-new-cypress branch December 15, 2022 21:33
@gmrabian gmrabian mentioned this pull request Sep 22, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macrael macrael macrael approved these changes

@haworku haworku haworku approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mojotalantikite @macrael @haworku