Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github workflows to avoid deprecations #11475

Merged
merged 3 commits into from
Oct 3, 2023
Merged

Conversation

gmrabian
Copy link
Contributor

@gmrabian gmrabian commented Oct 2, 2023

Description

Updating versions to avoid warnings and deprecations

Also modified deploy workflow to block using concurrency rather than lock script. That way only the deploy from the same branch can stop it, and it uses native github actions logic rather than custom scripts. we are already using this in CARTS and QMR. More info from QMR PR and docs for concurrency

Also fixes application endpoint output to show up in summary

Note: these have already been tested in another PR and I'm migrating them here

DOCS:
aws-configure-credentials readme – no breaking changes between 1 and 4. ("By default, your account ID will not be masked in workflow logs. This was changed from being masked by default in the previous version. AWS does not consider account IDs as sensitive information, so this change reflects that stance." Let me know if you want to mask this still and I'll add that option)
cache readme – no breaking changes with v3
codeclimate action changelog – breaking changes not relevant to us
node version action – update allows us to read from .nvmrc natively
pre-commit/action changelog – doesn't specifically call out a fix but the warnings were resolved by upgrading
actions/checkout changelog – v3 uses node 16 which will be deprecated soon but doesn't have a warning for now, and keeps it up to date with our other checkouts@v3
dependabot/fetch-metadata action changelog – specifically by changing to @v1 it will automatically use latest version

Related ticket(s)

MDCT-none


How to test

All steps here pass
View the step summaries and notice no deprecation warnings (compare to main or other branches)

@codeclimate
Copy link

codeclimate bot commented Oct 2, 2023

Code Climate has analyzed commit 5770a1e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 95.9% (0.0% change).

View more on Code Climate.

@gmrabian gmrabian added the ready for review Ready for all the reviews! label Oct 2, 2023
@gmrabian gmrabian merged commit f2563e3 into main Oct 3, 2023
@gmrabian gmrabian deleted the update-workflows branch October 3, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for all the reviews!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants