-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove happy-dom #1432
Merged
Merged
Remove happy-dom #1432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snyk has created this PR to upgrade happy-dom from 9.20.3 to 15.7.3. See this package in npm: happy-dom See this project in Snyk: https://app.snyk.io/org/eregs-x7s/project/bec2fb44-4372-4cd4-bac2-d5e881fde4db?utm_source=github&utm_medium=referral&page=upgrade-pr
✨ See the Django Site in action ✨ |
✨ See the Django Site in action ✨ |
PhilR8
changed the title
[Snyk] Upgrade happy-dom from 9.20.3 to 15.7.3
[Snyk] ~~Upgrade happy-dom from 9.20.3 to 15.7.3~~
Oct 1, 2024
PhilR8
changed the title
[Snyk] ~~Upgrade happy-dom from 9.20.3 to 15.7.3~~
Remove happy-dom
Oct 1, 2024
PhilR8
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vitest still works locally -- UI, coverage, tests all pass, everything works as expected.
Approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes from a human:
Instead of upgrading
happy-dom
, we are removing it. It was originally used for rendering Vue components in Vitest, but we use a different library,jsdom
, instead.happy-dom
can be safely removed and the PR does exactly this.Original text from a bot:
Snyk has created this PR to upgrade happy-dom from 9.20.3 to 15.7.3.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
The recommended version is 188 versions ahead of your current version.
The recommended version was released on a month ago.
Release notes
Package name: happy-dom
👷♂️ Patch fixes
HTMLSelectElement
- By @ Cherry in task #1526👷♂️ Patch fixes
MutationObserver
- By @ capricorn86 in task #1524👷♂️ Patch fixes
querySelector(['.class'])
) - By @ capricorn86 in task #1507🎨 Features
:has
pseudo selector - By @ capricorn86 in task #1373👷♂️ Patch fixes
Access-Control-*
,Origin
headers for cross-origin preflight requests - By @ rexxars in task #1489🎨 Features
:focus
and:focus-visible
- By @ capricorn86 in task #1515👷♂️ Patch fixes
HTMLInputElement
andHTMLTextAreaElement
- By @ capricorn86 in task #1487🎨 Features
Blob.stream()
- By @ PlopAndRun in task #1500👷♂️ Patch fixes
👷♂️ Patch fixes
👷♂️ Patch fixes
FormData.append()
when value parameter type is incorrect - By @ btea in task #1484Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information: