Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ✖️ with ❌ #29

Merged
merged 1 commit into from
Oct 16, 2020
Merged

Replace ✖️ with ❌ #29

merged 1 commit into from
Oct 16, 2020

Conversation

efaulhaber
Copy link
Contributor

@efaulhaber efaulhaber commented Oct 16, 2020 •
edited
Loading

Resolves #27.

@github-actions
Copy link

github-actions bot commented Oct 16, 2020 •
edited by EnricoMi
Loading

Unit Test Results

  1 files  ±0    1 suites  ±0   0s ⏱️ ±0s
24 tests ±0  24 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

results for commit e826078 ± comparison against base commit 3fefb1a

@EnricoMi
Copy link
Owner

I have changed this PR's unit test result comment manually, to reflect / demo your change. Can you add a screenshot of #29 (comment) here please?

@efaulhaber
Copy link
Contributor Author

efaulhaber commented Oct 16, 2020 •
edited
Loading

It looks like this for me on Windows 10:
grafik
In the GitHub app on Android it looks like this:

EnricoMi
EnricoMi approved these changes Oct 16, 2020
View reviewed changes
Copy link
Owner

@EnricoMi EnricoMi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better, let's go for it. Thanks!

@EnricoMi EnricoMi merged commit de7f7f0 into EnricoMi:master Oct 16, 2020
@github-actions

This comment has been minimized.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EnricoMi EnricoMi EnricoMi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make cross for failed tests red
2 participants
@efaulhaber @EnricoMi