Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme Customizer does not work for .enlighter-t-wpcustom .enlighter span #6

Closed
gruniversal opened this issue Apr 19, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@gruniversal
Copy link

Hello,

I am not sure if this is a bug, but I hope you can help me.

Environment

Story

  • previous version: 3.10, now have to update entries because of missing mocha-theme
  • used theme customizer to copy monokai to wpcustom
  • now trying to reduce font-size from 15px to 12px

Example

<!-- wp:enlighter/codeblock {"language":"php","theme":"wpcustom"} -->
<pre class="EnlighterJSRAW" data-enlighter-language="php" data-enlighter-theme="wpcustom" data-enlighter-highlight="" data-enlighter-linenumbers="" data-enlighter-lineoffset="" data-enlighter-title="" data-enlighter-group="">
if ($result = $mysqli->query("SELECT Name FROM City LIMIT 10")) {
    printf("Select returned %d rows.\n", $result->num_rows);
    $result->close();
}
</pre>
<!-- /wp:enlighter/codeblock -->

Problem:

  • cannot find a input-field to customize this entry:
.enlighter-t-wpcustom .enlighter span{
	font-size: 15px;
}

Since all tags are span, it is not possible to change the font-size.

Proposed solution

  • there should be a way to change font-size of span as well

Best regards,
David

@AndiDittrich
Copy link
Member

hi @gruniversal,

thanks for your feedback. the issue has already been arised.

EnlighterJS v3.3.0 already includes a em based font size which is derived from the outer container (global setting within the customizer) - implemented a few hours ago.

additionally a new generic group will be added to the Customizer which allowes the customization of the default token .enlighter span

@AndiDittrich AndiDittrich transferred this issue from EnlighterJS/Plugin.WordPress Apr 19, 2020
@AndiDittrich AndiDittrich added the enhancement New feature or request label Apr 19, 2020
@AndiDittrich
Copy link
Member

image

@gruniversal
Copy link
Author

Hello Andi,

I tried the new version 4.2 from GitHub (master, 20.4.2020) and it works on my staging system.

Thank you for your superfast reaction! That's impressive :)

Greetings from Leipzig,
David

@gruniversal
Copy link
Author

FYI: I wrote a script to migrate my codeblock entries from an old theme to a newer one and used it to successfully migrate from theme mocha to theme wpcustom.

It's very straightforward and only tested on my machine, but maybe someone will find it helpful:
https://gitlab.com/gruniversal/wp-enlighter-migration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants