Look for different output on ping to support ipv6 #2057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I worry that this would break for ipv4, have you tested that? :) |
|
I have just pushed a change that actually fixes all occurrences of the ping command, as there are also pings for general internet connectivity checks (these didn't cause problems before, because they default to ipv4). I have tested this on ipv4 by disabling ipv6 on the adapter connecting me to the internet, and the startup script functions normally under those conditions. |
NielsPilgaard
approved these changes
Oct 29, 2022
SSyl
pushed a commit
to SSyl/Enigmatica2Expert-SSylTweaks
that referenced
this pull request
Apr 17, 2023
Look for different output on ping to support ipv6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A minor fix that makes it such that the server installer/starter batch script no longer fails on ipv6-connections because the output for ping is different between ipv4 and ipv6. Instead of looking for
TTL=it looks fortime=.