Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spice of Life blacklist additions #2000

Merged
merged 2 commits into from
Jan 31, 2022

Conversation

AppleSaws
Copy link
Contributor

@AppleSaws AppleSaws commented Jan 31, 2022

This would add two items to the blacklist: carrot cake, which doesn't get added even when eaten (despite other similar cake-like items working just fine), and milk chocolate ingots, which aren't obtainable.

I was unable to find any mentions of the carrot cake not working with spice of life. As far as milk chocolate ingots though, there was this one post here: #1812
While it makes sense that one would be uninterested in taking the effort to remove the crafting recipe, adding it to the blacklist would be a really quick and easy fix.

This would add two items to the blacklist: carrot cake, which doesn't get added even when eaten (despite other similar cake-like items working just fine), and milk chocolate ingots, which aren't obtainable.
apparently I added an extra space. whoops
Copy link
Collaborator

@NielsPilgaard NielsPilgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! 😃

@NielsPilgaard NielsPilgaard merged commit b7acbe1 into EnigmaticaModpacks:master Jan 31, 2022
@NielsPilgaard NielsPilgaard changed the title blacklist additions Spice of Life blacklist additions Jan 31, 2022
@AppleSaws AppleSaws deleted the patch-1 branch January 31, 2022 23:38
@NielsPilgaard NielsPilgaard added Bug A modpack specific bug Enhancement and removed Bug A modpack specific bug labels Mar 7, 2022
SSyl pushed a commit to SSyl/Enigmatica2Expert-SSylTweaks that referenced this pull request Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants