New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added testcommon.etl function to write 'when' files to storage #84

Merged

henrik-t-caroe merged 25 commits into main from Brug-testcommon.etl-i-wholesale-data-products-view-executer#587

Jan 27, 2025

Contributor

henrik-t-caroe commented Jan 24, 2025 •

edited

Loading

Description

Added a 'write_when_files_to_delta()' function
Modified the 'get_then_names()' to accept a scenario path to reuse the code for generating scenario test cases.

Pull-request quality

The title adheres to this guide
Tests are written and executed locally
Subsystem tests have been tested (by manually deploying to dev_002)

JakobStricker added 17 commits

January 17, 2025 09:34


          Include view scenario executor + utils til Testcommon.etl

5fc8c2c


          Merge branch 'main' of https://github.com/Energinet-DataHub/opengeh-p…

2bbebe4

…ython-packages into Brug-testcommon.etl-i-wholesale-data-products-view-executer#587


          Update the view_scenario_executor.py to use be able to handle views i…

59374dc

…n the Wholesale repo


          Update the view_scenario_executor.py to use be able to handle views i…

ea3aa8f

…n the Wholesale repo


          Change the package path for the view_scenario_executor

e74fcc5


          Change the package path for the view_scenario_executor

a0593d9


          Change the package path for the view_scenario_executor

59a1458


          Change the package path for the view_scenario_executor

4d56616


          Change the package path for the view_scenario_executor

9d404d1


          write_to_delta.py

a46c406


          write_to_delta.py

cfcef1a


          write_to_delta.py

37e541a


          write_to_delta.py

a8cb691


          get_then_names.py

24e46e1


          get_then_names.py

ae4ee38


          get_then_names.py

69abd64


          get_then_names.py

9741a94

henrik-t-caroe requested review from a team as code owners

January 24, 2025 12:11

BjarkeMeier reviewed

View reviewed changes

source/testcommon/testcommon/dataframes/write_to_delta.py Show resolved Hide resolved

BjarkeMeier reviewed

View reviewed changes

source/testcommon/testcommon/dataframes/write_to_delta.py Show resolved Hide resolved

BjarkeMeier reviewed

View reviewed changes

source/testcommon/testcommon/dataframes/write_to_delta.py Outdated Show resolved Hide resolved

BjarkeMeier reviewed

View reviewed changes

source/testcommon/testcommon/dataframes/write_to_delta.py Show resolved Hide resolved

BjarkeMeier reviewed

View reviewed changes

source/testcommon/testcommon/etl/get_then_names.py Outdated Show resolved Hide resolved

BjarkeMeier reviewed

View reviewed changes

source/testcommon/testcommon/etl/get_then_names.py Outdated Show resolved Hide resolved

henrik-t-caroe changed the title ~~Brug testcommon.etl i wholesale data products view executer#587~~ feat: Added testcommon.etl function to write 'when' files to storage

Henrik Tornbjerg Carøe added 4 commits

January 27, 2025 09:47


          Added else clause and moved variable out of if-clause

d0923c2


          Added docstring to the write_to_delta

326288c


          Expanded the docstring for write_to_delta and get_then_names

e3464f2


          updated release notes and tags

9e6c771

henrik-t-caroe added 2 commits

January 27, 2025 13:47


          Modified release tag and version number

bdb1258


          Merge branch 'main' into Brug-testcommon.etl-i-wholesale-data-product…

1d5c99b

…s-view-executer#587

# Conflicts:
#	.github/workflows/create-release-tag.yml
#	source/testcommon/release-notes/release-notes.md

henrik-t-caroe had a problem deploying to AzureAuth

January 27, 2025 12:53

— with

GitHub Actions Failure


          Black formatting

a0a2e23

henrik-t-caroe temporarily deployed to AzureAuth

January 27, 2025 12:57

— with

GitHub Actions Inactive

BjarkeMeier reviewed

View reviewed changes

source/testcommon/setup.py Outdated Show resolved Hide resolved

BjarkeMeier previously approved these changes

View reviewed changes


          Updated version number

62b0004

henrik-t-caroe dismissed BjarkeMeier’s stale review via

62b0004

January 27, 2025 13:13

henrik-t-caroe temporarily deployed to AzureAuth

January 27, 2025 13:14

— with

GitHub Actions Inactive

henrik-t-caroe enabled auto-merge (squash)

January 27, 2025 13:20

BjarkeMeier approved these changes

View reviewed changes

henrik-t-caroe merged commit 1d72b1e into main

24 checks passed

henrik-t-caroe deleted the Brug-testcommon.etl-i-wholesale-data-products-view-executer#587 branch

January 27, 2025 13:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet