Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add async validation to BRS-026 #124

Merged
merged 19 commits into from
Jan 28, 2025
Merged

feat: Add async validation to BRS-026 #124

merged 19 commits into from
Jan 28, 2025

Conversation

ebbeknudsen
Copy link
Contributor

@ebbeknudsen ebbeknudsen commented Jan 23, 2025 •
edited
Loading

Description

  • Refactor BRS-026 & BRS-028 to use shared transition activities.
  • Add async validation pattern
  • Add (moved from Wholesale) async validation to BRS-026
  • Add (moved from Wholesale) async validation tests for BRS-026

References

Link to assignment: https://app.zenhub.com/workspaces/mosaic-60a6105157304f00119be86e/issues/gh/energinet-datahub/team-mosaic/375

Checklist

  • Should the change be behind a feature flag?
  • Can the feature be meaningfully disabled or circumvented if there are issues (e.g., database-breaking changes)?
  • Has it been considered whether data is being delivered to the wrong actor?
  • Subsystem test executed (dev_002/dev_003)
  • Is there time to monitor state of the release to Production?
  • Reference to the task

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 23, 2025 •
edited
Loading

Test results for \source\ProcessManager.Orchestrations.Tests\bin\Release\net8.0\Energinet.DataHub.ProcessManager.Orchestrations.Tests.dll

136 tests   134 ✅  2m 17s ⏱️
  1 suites    2 💤
  1 files      0 ❌

Results for commit 6741769.

♻️ This comment has been updated with latest results.

@ebbeknudsen ebbeknudsen enabled auto-merge (squash) January 27, 2025 10:46
RasmusGraabaek
RasmusGraabaek reviewed Jan 27, 2025
View reviewed changes
source/ProcessManager.Components/BusinessValidation/Helpers/PeriodValidationHelper.cs Show resolved Hide resolved
...ies/GetOrchestrationInstanceContextActivity_Brs_X02_NotifyOrchestrationInstanceExample_V1.cs Outdated Show resolved Hide resolved
..._X03_ActorRequestProcessExample/V1/BusinessValidation/ActorRequestProcessExampleValidator.cs Outdated Show resolved Hide resolved
...3_ActorRequestProcessExample/V1/Activities/EnqueueRejectedActorMessageActivity_Brs_X03_V1.cs Outdated Show resolved Hide resolved
...sses/BRS_026/V1/BusinessValidation/RequestCalculatedEnergyTimeSeriesInputV1ValidatorTests.cs Show resolved Hide resolved
...ions.Tests/Unit/Processes/BRS_026/V1/BusinessValidation/Rules/EnergySupplierValidatorTest.cs Show resolved Hide resolved
...hestrations.Tests/Unit/Processes/BRS_026/V1/BusinessValidation/Rules/PeriodValidatorTests.cs Show resolved Hide resolved
...Manager.Orchestrations/Processes/BRS_026/V1/BusinessValidation/Rules/PeriodValidationRule.cs Show resolved Hide resolved
@ebbeknudsen ebbeknudsen merged commit 9ac8021 into main Jan 28, 2025
30 checks passed
@ebbeknudsen ebbeknudsen deleted the xedkn/brs-026-028-async-validation branch January 28, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RasmusGraabaek RasmusGraabaek RasmusGraabaek approved these changes

@RSIEnerginet RSIEnerginet Awaiting requested review from RSIEnerginet RSIEnerginet is a code owner automatically assigned from Energinet-DataHub/team-mosaic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ebbeknudsen @RasmusGraabaek