Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set min-width and override maxheight for dropdown #2198

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Jaypeg85
Copy link
Contributor

Description

  • Set minimum width for downdown panel to 250px in case of small dropdowns
  • Set max-height of dropdown to 80vh to be able to show many more items in one view

References

@cla-bot cla-bot bot added the cla-signed label Oct 30, 2023
@nx-cloud
Copy link

nx-cloud bot commented Oct 30, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 59307c2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@mimse
Copy link
Contributor

mimse commented Nov 15, 2023

Question: Did you try getting it to dynamically resize depending on the largest item in the list? I think this would be better than a hard width of 250px, but i do not know if it is possible.

@Jaypeg85
Copy link
Contributor Author

Question: Did you try getting it to dynamically resize depending on the largest item in the list? I think this would be better than a hard width of 250px, but i do not know if it is possible.

I didn't try that, but I'm not sure it would be very nice, I might be wrong though. Maybe the min-width could be the size of the select?

Copy link

gitguardian bot commented Nov 22, 2023

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Copy link

[Energy Origin App] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

[DH3 Frontend App] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants