Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand eventhub resource with possibility to add consumer groups #282

Merged
merged 11 commits into from
Feb 6, 2024
Merged

Expand eventhub resource with possibility to add consumer groups #282

merged 11 commits into from
Feb 6, 2024

Conversation

jonasdmoeller
Copy link
Member

@jonasdmoeller jonasdmoeller commented Jan 25, 2024 •
edited
Loading

Description

Expanding the EventHubResource with possibility to add consumer groups. Based on the same builder pattern as adding subscriptions to the ServiceBus TopicResource.

Quality

  • Documentation is updated
  • Release notes are updated
  • Package version is updated
  • Public types and methods are documented
  • Tests are implemented and executed locally

@cla-bot cla-bot bot added the cla-signed label Jan 25, 2024
dstenroejl
dstenroejl reviewed Jan 25, 2024
View reviewed changes
Copy link
Contributor

@dstenroejl dstenroejl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments&suggestions.

Should we be able to easily set the consumer group name as an environment variable, or is this not useful from tests?

...mmon/source/FunctionApp.TestCommon/EventHub/ResourceProvider/EventHubConsumerGroupBuilder.cs Outdated Show resolved Hide resolved
...estCommon/source/FunctionApp.TestCommon/EventHub/ResourceProvider/EventHubResourceBuilder.cs Outdated Show resolved Hide resolved
@jonasdmoeller @dstenroejl
Update source/TestCommon/source/FunctionApp.TestCommon/EventHub/Resou…
6c9bfa8 
…rceProvider/EventHubResourceBuilder.cs

Co-authored-by: Dan Stenrøjl <[email protected]>
@jonasdmoeller
Copy link
Member Author

Added a few comments&suggestions.

Should we be able to easily set the consumer group name as an environment variable, or is this not useful from tests?

Good idea. This is now added.

dstenroejl
dstenroejl previously approved these changes Jan 25, 2024
View reviewed changes
dstenroejl
dstenroejl approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@dstenroejl dstenroejl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonasdmoeller jonasdmoeller merged commit 7c14229 into main Feb 6, 2024
22 checks passed
@jonasdmoeller jonasdmoeller deleted the jdm/expand-eventhubprovider-with-consumer-groups branch February 6, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstenroejl dstenroejl dstenroejl approved these changes

@FirestarJes FirestarJes Awaiting requested review from FirestarJes FirestarJes is a code owner

@Sondergaard Sondergaard Awaiting requested review from Sondergaard Sondergaard is a code owner

@HenrikSommer HenrikSommer Awaiting requested review from HenrikSommer HenrikSommer is a code owner

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonasdmoeller @dstenroejl