-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental object creation for Databricks statements #273
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #273 +/- ##
==========================================
+ Coverage 69.90% 70.03% +0.13%
==========================================
Files 26 215 +189
Lines 412 3808 +3396
Branches 33 451 +418
==========================================
+ Hits 288 2667 +2379
- Misses 114 990 +876
- Partials 10 151 +141
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…:Energinet-DataHub/geh-core into sondergaard/experimental-object-creation
source/Databricks/source/SqlStatementExecution/DatabricksSqlWarehouseQueryExecutor.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few suggestions
source/Databricks/source/SqlStatementExecution/Formats/Reflections.cs
Outdated
Show resolved
Hide resolved
source/Databricks/source/SqlStatementExecution/Formats/Reflections.cs
Outdated
Show resolved
Hide resolved
source/Databricks/source/SqlStatementExecution/Formats/Reflections.cs
Outdated
Show resolved
Hide resolved
source/Databricks/source/SqlStatementExecution.IntegrationTests/Client/ObjectCreationTests.cs
Show resolved
Hide resolved
source/Databricks/source/SqlStatementExecution/DatabricksSqlWarehouseQueryExecutor.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
source/Databricks/source/SqlStatementExecution.IntegrationTests/Client/ObjectCreationTests.cs
Outdated
Show resolved
Hide resolved
source/Databricks/source/SqlStatementExecution/DatabricksSqlWarehouseQueryExecutor.cs
Show resolved
Hide resolved
Co-authored-by: Dan Stenrøjl <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have committed Dan's test name suggestion and approved.
Description
First iteration of object creation for Databricks statements.
This is blocked by PR #272Quality