Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental object creation for Databricks statements #273

Merged
merged 18 commits into from
Nov 16, 2023

Conversation

Sondergaard
Copy link
Contributor

@Sondergaard Sondergaard commented Nov 15, 2023

Description

First iteration of object creation for Databricks statements.

This is blocked by PR #272

Quality

  • Documentation is updated
  • Release notes are updated
  • Package version is updated
  • Public types and methods are documented
  • Tests are implemented and executed locally

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (769f9bc) 69.90% compared to head (ba8a56f) 70.03%.

Files Patch % Lines
...ntExecution/DatabricksSqlWarehouseQueryExecutor.cs 75.00% 1 Missing and 3 partials ⚠️
...xecution/Formats/StronglyTypedApacheArrowFormat.cs 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #273      +/-   ##
==========================================
+ Coverage   69.90%   70.03%   +0.13%     
==========================================
  Files          26      215     +189     
  Lines         412     3808    +3396     
  Branches       33      451     +418     
==========================================
+ Hits          288     2667    +2379     
- Misses        114      990     +876     
- Partials       10      151     +141     
Flag Coverage Δ
databricks 73.88% <93.90%> (+3.98%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…:Energinet-DataHub/geh-core into sondergaard/experimental-object-creation
Copy link
Contributor

@dstenroejl dstenroejl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few suggestions

dstenroejl
dstenroejl previously approved these changes Nov 16, 2023
Copy link
Contributor

@dstenroejl dstenroejl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Dan Stenrøjl <[email protected]>
Copy link
Contributor

@HenrikSommer HenrikSommer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have committed Dan's test name suggestion and approved.

@Sondergaard Sondergaard merged commit e5d0229 into main Nov 16, 2023
19 checks passed
@Sondergaard Sondergaard deleted the sondergaard/experimental-object-creation branch November 16, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants