fix: DurableClientExtensions method WaitForOrchestationStartedAsync (#…

…493)
Energinet-DataHub · Jan 15, 2025 · ffbee4b · ffbee4b
1 parent eaae7a3
commit ffbee4b
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 4 deletions.
diff --git a/source/TestCommon/documents/release-notes/release-notes.md b/source/TestCommon/documents/release-notes/release-notes.md
@@ -1,5 +1,9 @@
 # TestCommon Release notes
 
+## Version 7.2.1
+
+- Fix bug in class `DurableClientExtensions` method `WaitForOrchestationStartedAsync` where an exception can be thrown if an orchestration with another name exists.
+
 ## Version 7.2.0
 
 - Extended class `DurableClientExtensions` with method `WaitForOrchestrationRunningAsync`.

diff --git a/source/TestCommon/source/DurableFunctionApp.TestCommon/DurableFunctionApp.TestCommon.csproj b/source/TestCommon/source/DurableFunctionApp.TestCommon/DurableFunctionApp.TestCommon.csproj
@@ -31,7 +31,7 @@ limitations under the License.
 
   <PropertyGroup>
     <PackageId>Energinet.DataHub.Core.DurableFunctionApp.TestCommon</PackageId>
-    <PackageVersion>7.2.0$(VersionSuffix)</PackageVersion>
+    <PackageVersion>7.2.1$(VersionSuffix)</PackageVersion>
     <Title>DurableFunctionApp TestCommon library</Title>
     <Company>Energinet-DataHub</Company>
     <Authors>Energinet-DataHub</Authors>

diff --git a/...ce/TestCommon/source/DurableFunctionApp.TestCommon/DurableTask/DurableClientExtensions.cs b/...ce/TestCommon/source/DurableFunctionApp.TestCommon/DurableTask/DurableClientExtensions.cs
@@ -58,13 +58,16 @@ public static async Task<DurableOrchestrationStatus> WaitForOrchestationStartedA
             {
                 var queryResult = await client.ListInstancesAsync(filter, CancellationToken.None).ConfigureAwait(false);
 
-                if (queryResult == null || !queryResult.DurableOrchestrationState.Any())
+                if (queryResult == null)
                     return false;
 
                 durableOrchestrationState = queryResult.DurableOrchestrationState
                     .Where(o => name == null || o.Name.Equals(name, StringComparison.OrdinalIgnoreCase))
                     .ToList();
 
+                if (durableOrchestrationState.Count == 0)
+                    return false;
+
                 if (durableOrchestrationState.Count > 1)
                     throw new Exception($"Unexpected amount of orchestration instances found. Expected 1, but found {durableOrchestrationState.Count}");
 

diff --git a/source/TestCommon/source/FunctionApp.TestCommon/FunctionApp.TestCommon.csproj b/source/TestCommon/source/FunctionApp.TestCommon/FunctionApp.TestCommon.csproj
@@ -31,7 +31,7 @@ limitations under the License.
 
   <PropertyGroup>
     <PackageId>Energinet.DataHub.Core.FunctionApp.TestCommon</PackageId>
-    <PackageVersion>7.2.0$(VersionSuffix)</PackageVersion>
+    <PackageVersion>7.2.1$(VersionSuffix)</PackageVersion>
     <Title>FunctionApp TestCommon library</Title>
     <Company>Energinet-DataHub</Company>
     <Authors>Energinet-DataHub</Authors>

diff --git a/source/TestCommon/source/TestCommon/TestCommon.csproj b/source/TestCommon/source/TestCommon/TestCommon.csproj
@@ -31,7 +31,7 @@ limitations under the License.
 
   <PropertyGroup>
     <PackageId>Energinet.DataHub.Core.TestCommon</PackageId>
-    <PackageVersion>7.2.0$(VersionSuffix)</PackageVersion>
+    <PackageVersion>7.2.1$(VersionSuffix)</PackageVersion>
     <Title>TestCommon library</Title>
     <Company>Energinet-DataHub</Company>
     <Authors>Energinet-DataHub</Authors>