This repository has been archived by the owner on May 8, 2023. It is now read-only.
fix: empty and whitespace elements for required elements when parsing cim document is now handled #1855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
x-platformcoder
requested review from
Mech0z,
lasrinnil,
prtandrup,
HenrikSommer,
jonasdmoeller and
ShaBloze
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1855 +/- ##
==========================================
- Coverage 84.39% 84.14% -0.26%
==========================================
Files 469 450 -19
Lines 8072 7888 -184
Branches 433 22 -411
==========================================
- Hits 6812 6637 -175
+ Misses 1174 1123 -51
- Partials 86 128 +42
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
x-platformcoder
changed the title
x-platformcoder
changed the title
x-platformcoder
changed the title
x-platformcoder
changed the title
…nto problem_with_whitespace_empty
...s/source/GreenEnergyHub.Charges.FunctionHost/Charges/Handlers/IChargeCommandBundleHandler.cs
Show resolved
Hide resolved
…nctionHost/Charges/Handlers/IChargeCommandBundleHandler.cs Co-authored-by: Henrik Sommer <[email protected]>
...ub.Charges/source/GreenEnergyHub.Charges.Infrastructure.Core/Function/HttpResponseBuilder.cs
Outdated
Show resolved
Hide resolved
...b.Charges/source/GreenEnergyHub.Charges.Infrastructure.Core/Function/IHttpResponseBuilder.cs
Outdated
Show resolved
Hide resolved
...gyHub.Charges.Infrastructure/CimDeserialization/ChargeBundle/ChargeCommandBundleConverter.cs
Show resolved
Hide resolved
...GreenEnergyHub.Charges.Infrastructure/CimDeserialization/MarketDocument/DocumentConverter.cs
Show resolved
Hide resolved
...GreenEnergyHub.Charges.Infrastructure/CimDeserialization/MarketDocument/DocumentConverter.cs
Show resolved
Hide resolved
...ergyHub.Charges.Infrastructure/CimDeserialization/MarketDocument/InvalidXmlValueException.cs
Show resolved
Hide resolved
...eenEnergyHub.Charges/source/GreenEnergyHub.Charges.Tests/GreenEnergyHub.Charges.Tests.csproj
Outdated
Show resolved
Hide resolved
...eenEnergyHub.Charges.IntegrationTest.Core/GreenEnergyHub.Charges.IntegrationTest.Core.csproj
Show resolved
Hide resolved
...enEnergyHub.Charges.Tests/Infrastructure/CimDeserialization/InvalidXmlValueExceptionTests.cs
Outdated
Show resolved
Hide resolved
...enEnergyHub.Charges.Tests/Infrastructure/CimDeserialization/InvalidXmlValueExceptionTests.cs
Outdated
Show resolved
Hide resolved
…nto problem_with_whitespace_empty # Conflicts: # source/GreenEnergyHub.Charges/source/GreenEnergyHub.Charges.Tests/Infrastructure/CimDeserialization/InvalidXmlValueExceptionTests.cs
|
Kudos, SonarCloud Quality Gate passed! |
HenrikSommer
approved these changes
Nov 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When CIM messages are parsed and required elements are either empty, only contain whitespace, or have a value that Charges do not support, and the possibility to handle those cases with asynchronous errors is not possible a bad request = "400" is returned with an error code "B2B-005" and an error message describing the problem as an XML message
References