Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Date Picker): use CSS logical properties instead of physical values #1106

Merged
merged 3 commits into from
Jul 22, 2024
Merged

refactor(Date Picker): use CSS logical properties instead of physical values #1106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4aa36fd
refactor(Date Picker): use CSS logical properties instead of physical…
Cata1989 Jun 12, 2024
d059b54
refactor(Date Picker): small update
Cata1989 Jun 20, 2024
9e82fd7
fix(Date picker): wrong utility to the bq-dropdown under the hood
dgonzalezr Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/beeq/src/components/date-picker/_storybook/bq-date-picker.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,8 @@ const Template = (args: Args) => {
? html`
<style>
bq-date-picker {
margin-top: -10rem;
width: 75vw;
margin-block-start: -10rem;
inline-size: 75vw;
}
</style>
`
Expand Down
2 changes: 1 addition & 1 deletion packages/beeq/src/components/date-picker/bq-date-picker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,7 +485,7 @@ export class BqDatePicker {
</label>
{/* Select date picker dropdown */}
<bq-dropdown
class="bq-date-picker__dropdown w-full [&::part(panel)]:w-auto [&::part(panel)]:p-m"
class="bq-date-picker__dropdown is-full [&::part(panel)]:p-m [&::part(panel)]:is-auto"
disabled={this.disabled}
distance={this.distance}
open={this.open}
Expand Down
24 changes: 12 additions & 12 deletions packages/beeq/src/components/date-picker/scss/bq-date-picker.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,15 @@
@import './bq-date-picker.variables';

:host {
@apply block w-full;
@apply block is-full;
}

/* -------------------------------------------------------------------------- */
/* Label */
/* -------------------------------------------------------------------------- */

.bq-date-picker__label {
@apply mb-[--bq-date-picker--label-margin-bottom] flex flex-grow items-center gap-[--bq-date-picker--gap];
@apply flex flex-grow items-center gap-[--bq-date-picker--gap] m-be-[--bq-date-picker--label-margin-bottom];
@apply text-[length:--bq-date-picker--label-text-size] text-[color:--bq-date-picker--label-text-color];
}

Expand All @@ -22,11 +22,11 @@
/* -------------------------------------------------------------------------- */

.bq-date-picker__control {
@apply flex w-full items-center transition-[border-color,box-shadow];
@apply flex items-center transition-[border-color,box-shadow] is-full;
// Border
@apply rounded-[--bq-date-picker--border-radius] border-[length:--bq-date-picker--border-width] border-[color:--bq-date-picker--border-color];
// Padding
@apply py-[--bq-date-picker--paddingY] pe-[--bq-date-picker--padding-end] ps-[--bq-date-picker--padding-start];
@apply pe-[--bq-date-picker--padding-end] ps-[--bq-date-picker--padding-start] p-b-[--bq-date-picker--paddingY];
// Text
@apply select-none text-[length:--bq-date-picker--text-size] text-[color:--bq-date-picker--text-color] placeholder:text-[color:--bq-date-picker--text-placeholder-color];
// Hover
Expand Down Expand Up @@ -93,7 +93,7 @@

.bq-date-picker__control--input {
@apply flex-auto cursor-[inherit] select-none appearance-none bg-[inherit] font-[inherit] text-[length:inherit] text-[color:inherit];
@apply m-0 min-h-[--bq-date-picker--icon-size] min-w-[0] border-none p-0 focus:outline-none focus-visible:outline-none;
@apply border-none min-bs-[--bq-date-picker--icon-size] min-is-0 m-b-0 m-i-0 p-b-0 p-i-0 focus:outline-none focus-visible:outline-none;
}

/* -------------------------------------------------------------------------- */
Expand All @@ -107,7 +107,7 @@
--bq-ring-offset-width: initial;
--bq-ring-color-focus: initial;

@apply h-auto rounded-xs border-none p-0;
@apply rounded-xs border-none bs-auto p-b-0 p-i-0;
}

/* -------------------------------------------------------------------------- */
Expand Down Expand Up @@ -148,16 +148,16 @@ calendar-multi {
}

&::part(heading) {
@apply px-xs py-xs2;
@apply p-b-xs2 p-i-xs;
}

&::part(button) {
@apply rounded-s border-0 bg-transparent p-xs2 transition-colors duration-200;
@apply rounded-s border-0 bg-transparent transition-colors duration-200 p-b-xs2 p-i-xs2;
@apply focus-visible:focus hover:bg-hover-ui-primary;
}

&::part(container) {
@apply bg-[--bq-date-picker--background-color] p-0;
@apply bg-[--bq-date-picker--background-color] p-b-0 p-i-0;
}
}

Expand All @@ -166,7 +166,7 @@ calendar-month {
--color-accent: var(--bq-ui--brand);

&::part(button) {
@apply flex items-center justify-center rounded-s bg-transparent p-0 font-default text-text-primary transition-colors duration-200 ease-in-out;
@apply flex items-center justify-center rounded-s bg-transparent font-default text-text-primary transition-colors duration-200 ease-in-out p-b-0 p-i-0;
@apply size-[--bq-date-picker--day-size] focus-visible:focus hover:bg-hover-bg-secondary;
}

Expand All @@ -179,7 +179,7 @@ calendar-month {
}

&::part(selected) {
@apply rounded-s text-[color:var(--bq-text--alt)];
@apply rounded-s text-[color:--bq-text--alt];
}

&::part(range-inner) {
Expand All @@ -193,7 +193,7 @@ calendar-month {
}

&::part(today selected) {
@apply text-[color:var(--bq-text--alt)];
@apply text-[color:--bq-text--alt];
}

&::part(today range-inner) {
Expand Down