Skip to content
This repository has been archived by the owner on Dec 4, 2023. It is now read-only.

Fix #2714: Allow setting security context of pods using persistent volumes #3538

Merged
merged 2 commits into from
Dec 5, 2019
Merged

Fix #2714: Allow setting security context of pods using persistent volumes #3538

merged 2 commits into from
Dec 5, 2019

Conversation

k-wall
Copy link
Member

@k-wall k-wall commented Dec 4, 2019 •
edited
Loading

Type of change

  • Enhancement / new feature

Description

Allows the security context of pods that use a persistent volume to be specified by
way of the CR that controls the resource.

Checklist

  • Update/write design documentation in ./documentation/design
  • Write tests and make sure they pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md

@k-wall k-wall added this to the 0.31 milestone Dec 4, 2019
@k-wall k-wall requested a review from lulf December 4, 2019 00:01
lulf
lulf reviewed Dec 4, 2019
View reviewed changes
Copy link
Member

@lulf lulf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, only a few minor comments.

pkg/apis/iot/v1alpha1/types_config.go Outdated Show resolved Hide resolved
pkg/apis/iot/v1alpha1/types_config.go Outdated Show resolved Hide resolved
pkg/controller/authenticationservice/standard.go Outdated Show resolved Hide resolved
lulf
lulf previously approved these changes Dec 4, 2019
View reviewed changes
Copy link
Member

@lulf lulf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; Nice work!

@k-wall
Copy link
Member Author

k-wall commented Dec 4, 2019

@lulf can re-review. The code should now work out of the box when installed in openshift-operators (well, except CRC - crc-org/crc#814)

lulf
lulf previously approved these changes Dec 4, 2019
View reviewed changes
@famarting
Copy link
Contributor

@enmasse-ci run tests testcase=OLMSpecificTest ocp4 OLM

@enmasse-ci
Copy link

✔️ Test Summary ✔️

TEST_PROFILE: pr
TEST_CASE: OLMSpecificTest
TOTAL: 2
PASS: 2
FAIL: 0
SKIP: 0

@k-wall
Copy link
Member Author

k-wall commented Dec 5, 2019

@enmasse-ci run tests profile=smoke

@enmasse-ci
Copy link

❌ Test Summary ❌

TEST_PROFILE: smoke
TEST_CASE:
TOTAL: 3
PASS: 2
FAIL: 1
SKIP: 0

❗ Test Failures ❗

  • smoketest in io.enmasse.systemtest.isolated.standard.SmokeTest

@k-wall
Copy link
Member Author

k-wall commented Dec 5, 2019

@enmasse-ci run tests profile=smoke

@enmasse-ci
Copy link

✔️ Test Summary ✔️

TEST_PROFILE: smoke
TEST_CASE:
TOTAL: 3
PASS: 3
FAIL: 0
SKIP: 0

@k-wall k-wall merged commit ef5708b into EnMasseProject:master Dec 5, 2019
@k-wall k-wall deleted the issue-2714 branch December 5, 2019 13:24
k-wall added a commit that referenced this pull request Dec 5, 2019
@k-wall
Fix #2714: Allow setting security context of pods using persistent vo…
1cbab05 
…lumes (#3538)

Manually merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lulf lulf lulf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.31.0
Development

Successfully merging this pull request may close these issues.
4 participants
@k-wall @famarting @enmasse-ci @lulf