update query records and request to download api #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tungntEmotiv
requested review from
nguoithichkhampha,
patemotiv,
thamha-emotiv and
tanpv
thamha-emotiv
approved these changes
Jul 3, 2023
nguoithichkhampha
requested changes
Jul 3, 2023
| @@ -105,7 +111,11 @@ def open(self): | |||
|
|
|||
| # As default, a Emotiv self-signed certificate is required. | |||
| # If you don't want to use the certificate, please replace by the below line by sslopt={"cert_reqs": ssl.CERT_NONE} | |||
| sslopt = {'ca_certs': "../certificates/rootCA.pem", "cert_reqs": ssl.CERT_REQUIRED} | |||
|
|
|||
| file_dir_path = os.path.dirname(os.path.realpath(__file__)) | |||
There was a problem hiding this comment.
should use high level package to handle file path
https://docs.python.org/3/library/pathlib.html
| @@ -92,6 +96,8 @@ def __init__(self, client_id, client_secret, debug_mode=False, **kwargs): | |||
| self.debit == value | |||
| elif key == 'headset_id': | |||
| self.headset_id = value | |||
| elif key == 'auto_create_session': | |||
There was a problem hiding this comment.
we should tell about optional params in readme file..
| @@ -272,6 +285,14 @@ def handle_result(self, recv_dic): | |||
| self.emit('mc_brainmap_done', data=result_dic) | |||
| elif req_id == SENSITIVITY_REQUEST_ID: | |||
| self.emit('mc_action_sensitivity_done', data=result_dic) | |||
| elif req_id == QUERY_RECORDS_ID: | |||
There was a problem hiding this comment.
why don't use switch case. it's more readable then a lot of if-else.
you can write
match req_id: case QUERY_RECORDS_ID:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR include:
Please help to review. Thanks