Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translation to Spanish #8

Merged
merged 4 commits into from
Nov 28, 2018
Merged

translation to Spanish #8

merged 4 commits into from
Nov 28, 2018

Conversation

vilarfg
Copy link
Contributor

@vilarfg vilarfg commented Nov 27, 2018

No description provided.

@EmielH
Copy link
Owner

EmielH commented Nov 27, 2018

Thanks a lot for this translation! It looks to me like the months are abbreviations of the month names, is that something that's commonly used in Spanish? The Dutch months have their full names translated, that's something I would like to keep consistent, but of course I don't know what's common in other countries. :)

@vilarfg
Copy link
Contributor Author

vilarfg commented Nov 28, 2018

I agree: consistency is important. In this scenario is a little tricky though, let me explain:

  • 28-feb-2018: OK
  • 28 de febrero de 2018: also OK (nicest option but longer though, I suggest you pick this one and made a new commit with full names for months)
  • 28-febrero-2018: understandable, but not really the way we display dates in Spanish.

@EmielH
Copy link
Owner

EmielH commented Nov 28, 2018

Thanks a lot, looks good to me! I'll merge this into master

@EmielH EmielH merged commit 96b488b into EmielH:master Nov 28, 2018
EmielH added a commit that referenced this pull request Nov 29, 2018
Posts appeared next to each other instead of below each other when the
title and summary were short enough.

See #8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants