Add table of contents. #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 25, 2022 04:09
It can be enabled using the `toc: true` field in the frontmatter. It auto-expands on hover. If JS is enabled, the expansion is animated. The animation is apparently impossible to implement without JS :( On mobile, expands and unexpands on tap instead of hover.
Why this works is a mystery, but it sure does.
|
Thanks for your contribution! It's a large one 😄 I had a quick look this weekend, will try to merge soon! |
|
(friendly ping) |
|
Thanks for the ping. My apologies - I've had a busy couple of weeks! |
|
Thanks! I can relate to the busy couple of weeks part :) TBH I was expecting a long and meticulous code review given my experience in frontend development (or lack thereof), but if I managed to clear the quality bar on the first go, all the better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only tested on a Chromebook and Firefox on Android.