Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog title is h1 on homepage #53

Merged
merged 2 commits into from
Aug 23, 2021
Merged

Blog title is h1 on homepage #53

merged 2 commits into from
Aug 23, 2021

Conversation

gavinr
Copy link
Contributor

@gavinr gavinr commented Aug 20, 2021

partially resolves #52

@EmielH
Copy link
Owner

EmielH commented Aug 22, 2021

Thank you very much for your contribution! This is a good catch. I wonder if on the article page, the title of the blog shouldn't be an <h1> too while the title of the article becomes an <h2>. This would probably fit the hierarchy better, while the title of the article can still be larger thanks to styling.

@gavinr
Copy link
Contributor Author

gavinr commented Aug 22, 2021

It's best-practice on the article page to have the post title be the only H1 on the page. See the example of the official WordPress Twenty-One theme, for example: https://wp-themes.com/twentytwentyone/?p=19

image

@EmielH
Copy link
Owner

EmielH commented Aug 23, 2021

That makes sense too. There's something to say for both approaches I guess! I can even consider removing the header tag from the site title altogether.

For now, I will accept your pull requests. Thanks again for your contribution!

@EmielH EmielH merged commit 2feda5a into EmielH:master Aug 23, 2021
@gavinr
Copy link
Contributor Author

gavinr commented Aug 23, 2021

You're welcome. Thank you for maintaining this project!

@gavinr gavinr deleted the patch-1 branch August 23, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple <h1> tags on home page
2 participants