Console app dev #44
Open
Console app dev #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonHeimberg
commented
Mar 3, 2020
SimonHeimberg
commented
Mar 3, 2020
Comment on lines
+24
to
+25
| "symfony/twig-bridge": "^3.1|^4.1|^5.0", | ||
| "symfony/yaml": "^3.1|^4.1|^5.0" |
There was a problem hiding this comment.
How many dependencies does this pull in? Do we care?
There was a problem hiding this comment.
twig-bridge does symfony/translation-contracts, twig/twig (doing symfony/polyfill-ctype and symfony/polyfill-mbstring)
yaml only symfony/polyfill-ctype
There was a problem hiding this comment.
having only accepted this pr partially broke some checks of check-commit-cube.sh in this bundle
Twig test will fail on many functions it does not know.
SimonHeimberg
force-pushed
the
consoleAppDev
branch
from
d0efa65 to
a419ce9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.