Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataDogAudit] indicate unknown changes less obtrusive #149

Open
SimonHeimberg opened this issue Jun 15, 2020 · 2 comments
Open

[DataDogAudit] indicate unknown changes less obtrusive #149

SimonHeimberg opened this issue Jun 15, 2020 · 2 comments

Comments

@SimonHeimberg
Copy link
Contributor

SimonHeimberg commented Jun 15, 2020

When the associations have changed (in the class), DataDogAudit::getAttributeNameForNtoN() throws a ContextErrorException in dev mode.

Possibilities:

  • just warn when this happens
  • show a note in the audit log (do indicate that something is missing)
  • other method to get the correct attribute name
  • ...
@SimonHeimberg
Copy link
Contributor Author

SimonHeimberg commented Jun 15, 2020

This should work and only be triggered in debug mode:

* Reports a non-fatal logic exception, only shown in debug mode.

To check: is @ missing before trigger_error?

Maybe it should be handled different. dump() in dev mode? Trigger a deprecation?

the idea is:

  • report to the developper in case something is configured wrong
  • the user can use it anyway

@SimonHeimberg SimonHeimberg changed the title [DataDogAudit] support unknown changes [DataDogAudit] indicate unknown changes less obtrusive Jun 16, 2020
@SimonHeimberg
Copy link
Contributor Author

mtubis votes for dump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant