Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nestingDetection undefined (cpp_server_source.template) #441

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

gin-c
Copy link

@gin-c gin-c commented Dec 19, 2024

Pull request

Choose Correct

  • bug
  • feature

Describe the pull request

fix nestingDetection undefined

To Reproduce

Expected behavior

extern bool nestingDetection;
bool nestingDetection = false;

Screenshots

image

Desktop (please complete the following information):

  • OS: Ubuntu
  • eRPC Version: 1.13.0

Steps you didn't forgot to do

  • I checked if other PR isn't solving this issue.
  • I read Contribution details and did appropriate actions.
  • PR code is tested.
  • PR code is formatted.
  • Allow edits from maintainers pull request option is set (recommended).

Additional context

@amgross
Copy link
Contributor

amgross commented Dec 19, 2024

  1. This is defined at erpc_server.cpp
  2. I think defining it in the template may cause multiple definition of it in case of using multiple services

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants