Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Prevent uri-modification on redirect_uri-handling #28

Merged
merged 4 commits into from
Aug 8, 2024

Conversation

MarcusGrass
Copy link
Contributor

Checklist

  • I have read the Contributor Guide
  • I have read and agree to the Code of Conduct
  • I have added a description of my changes and why I'd like them included in the section below

Description of Changes

Fixes up unexpected url-modification when sending the redirect_uri, don't send code_verifier on refreshes, that's not in-spec as far as I could tell.

Copy link
Member

@theCarlG theCarlG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@bwestlin bwestlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 lgtm

@MarcusGrass MarcusGrass merged commit e41f86b into main Aug 8, 2024
7 checks passed
@MarcusGrass MarcusGrass deleted the mg/no-slash-test branch August 8, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants