Intern, as DataInstForm, the kind and output_type fields of DataInstDef.
#28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will merge before #29 is ready, as that's quite literally an order of magnitude bigger already, and there's no reason to further complicate rebases by delaying this any longer. |
github-merge-queue bot
pushed a commit
to Rust-GPU/spirt
that referenced
this pull request
Nov 6, 2024
…`). (#12) Effectively undoes: - EmbarkStudios/spirt#28 Some quick unscientific testing reveals no significant perf impact (i.e. the difference is lost in the noise). The motivation for undoing this interning is the prospect of combining `DataInstDef` into `NodeDef` (as mentioned in #7), and for unrelated pragmatic reasons, `NodeDef` can't have its outputs interned (though long-term maybe we could intern the `kind` field, if really necessary, assuming we first take "child regions" out of it). The one thing I realized too late there's no pre-existing consensus for, is the `output_type`, which used to be between `kind` and `inputs` (matching `DataInstFormDef`, in fact), while `NodeDef`'s `outputs` is the last field. The only argument to have outputs first is the `let (out0, out1) = foo(in0, in1);` style syntax (though pretty-printed SPIR-T omits the `let`), but I'm not sure that's worth flipping the order over.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should, in theory, allow reusing one
DataInst"form" (or "template") for manyDataInsts, with only runtime inputs (and/or attributes) differing between their "instances".While there is no good reason to have the extra indirection today (and the performance impact seems to fall within noise), there is a refactor I want to try (which would require multiple outputs per
DataInst, and that would add to the growing size ofDataInstDef, before this interning change).Will keep this PR as draft until I can confirm that refactor is successful.