Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update glam #220

Merged
merged 1 commit into from
Nov 11, 2020
Merged

Update glam #220

merged 1 commit into from
Nov 11, 2020

Conversation

XAMPPRocky
Copy link
Member

No description provided.

examples/shaders/sky-shader/src/lib.rs Outdated Show resolved Hide resolved
@mergify mergify bot merged commit c2ccdbe into main Nov 11, 2020
@mergify mergify bot deleted the update-glam branch November 11, 2020 08:13
@fu5ha
Copy link
Member

fu5ha commented Nov 11, 2020

Hm, I'm not sure I like the approach of publicly re-exporting glam from spirv_std, especially if we want the separation of concerns discussed in #223. I think this also makes it harder to integrate with macaw to add extensions on top of glam that way. I might go back to the old way in #222 but with the newer glam version

@XAMPPRocky
Copy link
Member Author

XAMPPRocky commented Nov 12, 2020

I don't have strong opinions, I re-exported from glam because when glam is updated having it as a [crates-io.patch] means that when the version is incompatible cargo will warn that the patch is unused and continue trying to build with the version on crates.io, which I was encountering a lot. Having it as a direct dependency prevents that, and it allows people to use and test the in progress spirv fork of glam without finding a PR on GitHub. Once there's a published version on crates.io I think we can pull it back out.

@MarijnS95 MarijnS95 mentioned this pull request Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants