Skip to content

Commit

Permalink
Audit 'android-activity' v0.4.1 (#94)
Browse files Browse the repository at this point in the history
  • Loading branch information
rib authored Jun 8, 2023
1 parent 4b36a88 commit dfa6e9b
Showing 1 changed file with 17 additions and 0 deletions.
17 changes: 17 additions & 0 deletions audits.toml
Original file line number Diff line number Diff line change
Expand Up @@ -885,6 +885,23 @@ criteria = "safe-to-deploy"
version = "1.0.0"
notes = "No unsafe usage or ambient capabilities. No functionality in it beyond a #[test]. "

[[audits.android-activity]]
who = "Robert Bragg <[email protected]>"
criteria = "safe-to-deploy"
version = "0.4.1"
notes = """Some unsafe usage for JNI/FFI, such as implementing extern \"C\" functions for
NativeActivity and to use the `ndk_sys` FFI bindings for the Android NDK libraries.
The GameActivity backend depends on around 2k lines of third-party C/C++ code from Google
as well as around 500 lines of C++ code for the GameText (input method) support.
The C/C++ code is compiled with the `cc` crate.
Although I have reviewed all of the C/C++ code for GameActivity + GameText there
could be unknown soundness issues in there or potentially in any of the Android
NDK APIs used, which are generally also implemented in C/C++.
Written by Robert Bragg who now works at Embark Studios.
"""

# ------------------------------------------------------------------------------------------
# third party crates that we haven't audited, but we trust the author and release process of
Expand Down

0 comments on commit dfa6e9b

Please sign in to comment.