-
Notifications
You must be signed in to change notification settings - Fork 18
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Audit 'android-activity' v0.4.1 (#94)
- Loading branch information
Showing
1 changed file
with
17 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -885,6 +885,23 @@ criteria = "safe-to-deploy" | |
version = "1.0.0" | ||
notes = "No unsafe usage or ambient capabilities. No functionality in it beyond a #[test]. " | ||
|
||
[[audits.android-activity]] | ||
who = "Robert Bragg <[email protected]>" | ||
criteria = "safe-to-deploy" | ||
version = "0.4.1" | ||
notes = """Some unsafe usage for JNI/FFI, such as implementing extern \"C\" functions for | ||
NativeActivity and to use the `ndk_sys` FFI bindings for the Android NDK libraries. | ||
The GameActivity backend depends on around 2k lines of third-party C/C++ code from Google | ||
as well as around 500 lines of C++ code for the GameText (input method) support. | ||
The C/C++ code is compiled with the `cc` crate. | ||
Although I have reviewed all of the C/C++ code for GameActivity + GameText there | ||
could be unknown soundness issues in there or potentially in any of the Android | ||
NDK APIs used, which are generally also implemented in C/C++. | ||
Written by Robert Bragg who now works at Embark Studios. | ||
""" | ||
|
||
# ------------------------------------------------------------------------------------------ | ||
# third party crates that we haven't audited, but we trust the author and release process of | ||
|