Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Embark standard lints v0.2 #128

Merged
merged 1 commit into from
Mar 10, 2021
Merged

Use Embark standard lints v0.2 #128

merged 1 commit into from
Mar 10, 2021

Conversation

repi
Copy link
Contributor

@repi repi commented Mar 6, 2021

Switches to use our new standard template for defining shared Rust and Clippy lints for our Embark projects, EmbarkStudios/rust-ecosystem#59.

Did a couple of lint fixes from this but didn't want to make the change too intrusive so added some allow exceptions for now that can be revisited

Switches to use our new standard template for defining shared Rust and Clippy lints for our Embark projects, EmbarkStudios/rust-ecosystem#59.

Did a couple of lint fixes from this but didn't want to make the change too intrusive so added some allow exceptions for now that can be revisited
Copy link
Member

@tgolsson tgolsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@repi I'm fine with merging this, but who is responsible for keeping this updated and making relevant changes if our standard changes?

Copy link
Contributor

@hrydgard hrydgard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with the same thought as Tom.

@repi
Copy link
Contributor Author

repi commented Mar 9, 2021

@tgolsson @hrydgard think it should be part of regular maintenance by primarily the codeowners of the crates. But after this is merged it is not an urgent thing to upgrade to the latest lint collection rapidly, one can do when one is doing other changes similar to updating dependencies and such.

And a few of us will probably do some drive-by updates like this and submit PRs occasionally to test out new lints and fix up code, but think the main responsibility should be on the codeowners for the larger crates, like every few months or so or when doing other larger changes or maintenance.

@repi repi merged commit 3ac00ed into main Mar 10, 2021
@repi repi deleted the embark-lints-v0.2 branch March 10, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants