Fix filtering for workspace crates comparing canonical with non-canonical paths #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For me test Edit: |
mergify bot
pushed a commit
to EmbarkStudios/cargo-deny
that referenced
this pull request
Nov 14, 2024
This PR adds a new command line flag `--exclude-unpublished`. If the flag is set, the construction of the crate graph does not use explicitly unpublished crates as roots. Workspace members are considered explicitly unpublished if their manifest specifies `publish = false`. For motivation please see the [associated issue](#708). This PR depends on EmbarkStudios/krates#94 to fix the workspace filters mechanism of https://github.com/EmbarkStudios/krates. Documentation for the flag will follow as soon as I find the time. --------- Co-authored-by: Jake Shadle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of Changes
When workspace filters (paths to workspace members' manifest) are added to the builder, the paths are automatically canonicalized. In the later checking against these filters the paths taken from the metadata are not canonical. This lead to no filter being able to match at all.
Related Issues
This fix is a prerequisite for my work on adding the
--exclude-unpublishedcrates for cargo deny.Please let me know if you also want me to open an issue in this repository to reference in this PR