Fix crate pruning #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the graph was built by going from each root package to each of its dependencies recursively until all packages that were referenced were visited. This mostly worked fine, however had issues, namely #60, that were caused by there being tension between our view of the graph and cargo metadata's. `cargo metadata` presents a "complete" view of a graph, however if a user requested only packages for specific platforms or only of specific kinds, we were still including features that `cargo metadata` had resolved with its complete view of the graph, even if those features were only enabled by an edge that was otherwise pruned. So now, we just does our own resolution by recursively walking each package + feature combination rooted at the features enabled on each root crate which allows us to accurately prune nodes as we go rather than doing complicated fixup passes or the like
Jake-Shadle
force-pushed
the
fix-pruning
branch
from
ccf7eca to
0b5bd19
Compare
Jake-Shadle
force-pushed
the
fix-pruning
branch
from
0b5bd19 to
bf2b1b8
Compare
stefan-k
pushed a commit
to stefan-k/argmin
that referenced
this pull request
Mar 7, 2024
…EmbarkStudios/krates#61 arrives in cargo-deny-action.
stefan-k
pushed a commit
to argmin-rs/argmin
that referenced
this pull request
Jan 6, 2025
…EmbarkStudios/krates#61 arrives in cargo-deny-action.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the graph was built by going from each root package to each of its dependencies recursively until all packages that were referenced were visited. This mostly worked fine, however had issues, namely #60, that were caused by there being tension between our view of the graph and cargo metadata's.
cargo metadatapresents a "complete" view of a graph, however if a user requested only packages for specific platforms or only of specific kinds, we were still including features thatcargo metadatahad resolved with its complete view of the graph, even if those features were only enabled by an edge that was otherwise pruned.So now, we just does our own resolution by recursively walking each package + feature combination rooted at the features enabled on each root crate which allows us to accurately prune nodes as we go rather than doing complicated fixup passes or the like
Resolves: #60