Add prefer-index feature
#47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
prefer-indexfeature which attempts to use features declared on the crate in the index, rather than relying on the crate metadata. The reason for this is a bug/problem in cargo and/or the crates.io registry depending on how you look at it, where the index, which is the source of truth when resolving crates and their features, can be different from the package metadata sourced from the manifest for the crate version in question, see rust-lang/cargo#11319 for more info. If the feature is turned off we just (silently) ignore the features that have been resolved, but don't exist in the crate metadata, though of course doesn't handle cases where the package metadata was actually completely wrong in terms of have different subfeatures in a feature, but we can't know that unless we look at the index.Resolves: #46