Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lints to embark lints 0.3 #2

Merged
merged 2 commits into from
Mar 23, 2021
Merged

Update lints to embark lints 0.3 #2

merged 2 commits into from
Mar 23, 2021

Conversation

DeanBDean
Copy link
Contributor

@DeanBDean DeanBDean commented Mar 20, 2021 •
edited by Jake-Shadle
Loading

Checklist

  • I have read the Contributor Guide
  • I have read and agree to the Code of Conduct
  • I have added a description of my changes and why I'd like them included in the section below

Description of Changes

Updated embark lints and made minor changes to please the linter

Related Issues

Resolves #1

Jake-Shadle
Jake-Shadle requested changes Mar 22, 2021
View reviewed changes
Copy link
Member

@Jake-Shadle Jake-Shadle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This looks good, other than that the Cargo.lock file was updated unnecessarily.

@Jake-Shadle Jake-Shadle changed the title refactor: update lints to embark lints 0.3 Update lints to embark lints 0.3 Mar 22, 2021
@DeanBDean
Copy link
Contributor Author

@Jake-Shadle Unfortunately I had to update the Cargo.lock file to pull hyper past a version that had an exploit. cargo-deny would not pass otherwise. I should have mentioned that in the "Description of Changes" section, but I discovered that issue after I wrote that and forgot to circle back and amend it.

@Jake-Shadle Jake-Shadle self-requested a review March 23, 2021 07:19
Jake-Shadle
Jake-Shadle approved these changes Mar 23, 2021
View reviewed changes
Copy link
Member

@Jake-Shadle Jake-Shadle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, FWIW you can update a single package with cargo update -p <name> instead of the entire lockfile in the future. 😉

@Jake-Shadle Jake-Shadle merged commit 6ed7c9b into EmbarkStudios:main Mar 23, 2021
@DeanBDean
Copy link
Contributor Author

@Jake-Shadle I did not know that, thanks I will do that in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jake-Shadle Jake-Shadle Jake-Shadle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to v0.3 of Embark's standard lints
2 participants
@DeanBDean @Jake-Shadle