Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Windows 32-bit x86 support #68

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Add Windows 32-bit x86 support #68

merged 1 commit into from
Nov 30, 2022

Conversation

gabrielesvelto
Copy link
Contributor

Checklist

  • [✓] I have read the Contributor Guide
  • [✓] I have read and agree to the Code of Conduct
  • [✓] I have added a description of my changes and why I'd like them included in the section below

Description of Changes

Added support for 32-bit x86 targets on Windows by providing an implementation of capture_context().

Related Issues

None

Jake-Shadle
Jake-Shadle approved these changes Nov 30, 2022
View reviewed changes
Copy link
Member

@Jake-Shadle Jake-Shadle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll commit this for now, but I'll add an issue for actually building and testing i686-pc-windows-msvc later before I'll cut a release with it.

@mergify mergify bot merged commit a8679cf into EmbarkStudios:main Nov 30, 2022
@Jake-Shadle Jake-Shadle mentioned this pull request Nov 30, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jake-Shadle Jake-Shadle Jake-Shadle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabrielesvelto @Jake-Shadle