Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #62.
Support handling of
SIGABRT
on windows. While this is not generally useful in rust, due tostd::process::abort
using the fastfail mechanism which bypasses exception handling and signal emission, it is useful when there is C/C++ code involved, as, for example,assert
will callabort
.This also replaces the
windows-sys
dependency inminidumper
withwinapi
aswindow-sys
version churn has been incredibly annoying to deal with, and most projects still havewinapi
dependencies through other crates. This is probably temporary and we'll just write the bindings we need manually later since they aren't publicly exposed so there is no need to interoperate with other crates.This also changes it so that sadness-generator now does
libc::abort
instead ofstd::process::abort
so that all the platforms the crates in this repo support have the same signal based abort testing.