Add inital MacOS implementation #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to safely jump from the exception handler code to eg. release locks, as it appears this will be needed on mac due to how exception ports work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the initial MacOS implementation for crash-context, exception-handler, and minidumper. This PR heavily depends on rust-minidump/minidump-writer#21 for the minidump write implementation.
Other notable changes:
CrashEventResulttype returned from the user callback registered with the exception handler, which can either beHandled(bool)covering the previous use case, but can also be aJumpspecifying a jump buffer and value. This allows the exception handler to cleanly cleanup its state (eg unlock mutexes) before long jumping to the specified location. This functionality was only used in testing before, but there's no reason it can't be part of the user API in cases where users know they are about to raise an exception and want to be able to handle it gracefully....except for MacOS! Since MacOS delivers exceptions to a separate thread, we can't longjump from it back to the point in the user thread that raised the exception, at least, not in a way that I know of.Resolves: #3