fix elm make command to utilize the new elm make rather than elm-make #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bekicot
reviewed
May 28, 2019
|
Please to merge. |
bukzor
approved these changes
Dec 31, 2019
|
Is there any reason we are not merging this change yet? |
|
Looking forward to this merge 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I figured I'd send this in to start a discussion. There are still some of the commands that don't work right yet because they are still relying on the old style of calling them. Specifically the ElmMakeMain and ElmRepl. Either way, I'd like to fully address #164.
I didn't know if you'd prefer those to all be in separate PR's and I wasn't positive if you wanted backwards compatibility if someone is using an old version of Elm. Either way, I'm happy to do seperate PR's, one large PR and to make a stab at making it backwards compatible as well.
👍