This repository has been archived by the owner on Jun 24, 2023. It is now read-only.
add multi monitor screenshare support #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DemiMarie
suggested changes
Mar 30, 2022
receiver/receiver.py
Outdated
Comment on lines
68
to
69
| if untrusted_width > screen.width() or untrusted_height > screen.height() or untrusted_fps > 4096: | ||
| print('warning: excessive width, height, and/or fps') |
There was a problem hiding this comment.
untrusted_fps being too large is definitely an error. I really do not want to allow untrusted_width * untrusted_height that exceeds INT_MAX / 4, or other values that risk causing integer overflow downstream.
- change excessive width / height / fps runtime error to a warning (multi monitor screenshare often exceeds this check) - add parameter for qubes-video-companion screenshare [screenId] which enables a user to share a specific screen only Signed-off-by: jampe <[email protected]>
Signed-off-by: jampe <[email protected]>
Signed-off-by: jampe <[email protected]>
|
Thanks for reviewing this. To elaborate on the set limits: I hardly think someone will do screen sharing with more than 60 fps. Additionally I've set the max width / height to 3 x 4k what should hopefully be enough for everyone... Let me know if you'd like different limits. cheers |
DemiMarie
suggested changes
Mar 30, 2022
sender/screenshare.py
Outdated
| args.insert(3, "endx={}".format(geometry.x+geometry.width-1)) | ||
| args.insert(4, "endy={}".format(geometry.y+geometry.height-1)) | ||
|
|
||
| print(" ".join(args)) |
There was a problem hiding this comment.
Suggested change
| print(" ".join(args)) |
This would break the receiver, which isn’t expecting this line.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements multi monitor screen share support.