Skip to content

Commit

Permalink
deps: patch V8 to 12.4.254.18
Browse files Browse the repository at this point in the history
Refs: v8/v8@12.4.254.17...12.4.254.18
PR-URL: nodejs#53054
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
  • Loading branch information
nodejs-github-bot authored and EliphazBouye committed Jun 20, 2024
1 parent 59e10fb commit 5da02c9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion deps/v8/include/v8-version.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
#define V8_MAJOR_VERSION 12
#define V8_MINOR_VERSION 4
#define V8_BUILD_NUMBER 254
#define V8_PATCH_LEVEL 17
#define V8_PATCH_LEVEL 18

// Use 1 for candidates and 0 otherwise.
// (Boolean macro values are not supported by all preprocessors.)
Expand Down
2 changes: 1 addition & 1 deletion deps/v8/src/builtins/builtins-array.cc
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ inline bool HasOnlySimpleElements(Isolate* isolate,
DisallowGarbageCollection no_gc;
PrototypeIterator iter(isolate, receiver, kStartAtReceiver);
for (; !iter.IsAtEnd(); iter.Advance()) {
if (IsJSProxy(iter.GetCurrent())) return false;
if (!IsJSObject(iter.GetCurrent())) return false;
Tagged<JSObject> current = iter.GetCurrent<JSObject>();
if (!HasSimpleElements(current)) return false;
}
Expand Down

0 comments on commit 5da02c9

Please sign in to comment.