-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong rect displaying #95
Comments
@Kozinaka I have found the source of the issue, but there is no fix needed. In both conversion (see the Xaml Output), a root clipping region is added due to the defined size of 32 by 32. <DrawingGroup.ClipGeometry>
<RectangleGeometry Rect="0,0,32,32" />
</DrawingGroup.ClipGeometry> The clipping region in the output is affecting the "wrong" output file. There is no need for a fix because the conversion settings allow you to turn on or off the root clipping region through a property named IgnoreRootViewbox, which is I will update the WpfSvgTestBox application to make the conversion settings available to turn on or off the options and observe the effects on the outputs. |
But both files contains one single green rect [0,0,32,32] inside of it in Inkscape and both of it have clip region [0, 0, 32, 32]! Why "wrong" file have something outside [0,0,32,32] when output in SharpVectors? |
Nice observation, thank you. It is a bug in the current |
Fixed a bug in the SvgNumber.ScientificToDec method. This fixes the issue #95
Thanks for submitting this issue, I think it have now fixed it in the committed code 5bc4324. |
Build is broken :) |
Sorry, but my local repository is not broken!!! |
The SvgTransform class was updated. #95
The review will take time, I think committing the SvgTransform class will fix the problem build. |
Finally committed all the local changes: ad7b893 |
But now it explodes in runtime when loading some icons. :) |
@Kozinaka Sorry, I could not reproduce this latest issue. The attached icon is rendered normally as shown below: |
This will fix issues with parsing number on more localized Windows such as the Russian Windows. Should fix the updated issue #95
@Kozinaka Not having access to Russian Windows (only English and Japanese) but was able to reproduce the parsing error with |
There are sample of two similar files with single rect 32x32 px size. Both of them editable by Inkscape and don't change it's behaviour after resaving in it. Right.svg displaying right, Wrong.svg displaying with error (rendered rect is smaller than expected).
Files to test: Samples.zip
The text was updated successfully, but these errors were encountered: