Feature/bravo 2638 add timeout #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added the dependency vulnerability checker - Added the dependency version checker
Create SECURITY.md
BRAVO-666 - Create release artifact after creating the release
Updates `getBuildConfig` in the OpenShift client to use the registry secret to pull the base Docker image. When OpenShift is used to create new Docker images, a "BuildConfig" is created. This build config provides OpensShift with instructions on how to build the Docker image. The current build config was using a secret to push the build image into a registry, but it was not using this secret when pulling the base Docker image. This means that it only worked for base images in registries that allow anonymous access. This commit updates the BuildConfig to use the registry secret when pulling the image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
(Explain what this PR contributes to the codebase)
Submitting a Pull Request
Please see the Description of the PR Process.
Submitter's Pledge
Reviewers, I have verified the following to the best of my knowledge:
CHANGELOG.mdwith the new target version (or with theUnreleasedtag) and updated the version comparison url in the file.README.mdat the repo root and all of the applicableREADME.mdfiles underdocs/**along with necessary version change for code samples in those docs where applicable.Review Recommendation
(
Describe if you have any specific review recommendation to the reviewers such as:
)