Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the standard trick for BuildAbortionStage #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jglick
Copy link

@jglick jglick commented Jun 30, 2021

Summary

Avoids using non-sandbox-friendly methods to abort previous builds, using the standard workaround for JENKINS-43353. (Requires the pipeline-milestone-step plugin.) jenkinsci/workflow-job-plugin#200 would be nicer.

Submitter's Pledge

Reviewers, I have verified the following to the best of my knowledge:

  • I have added unit test cases for the changes where applicable.
  • I have updated CHANGELOG.md with the new target version (or with the Unreleased tag) and updated the version comparison url in the file.
  • I have updated documentation in README.md at the repo root and all of the applicable README.md files under docs/** along with necessary version change for code samples in those docs where applicable.
  • I have read and fully understand the process for submitting a pull request to the codebase.

Review Recommendation

Not sure whether this is tested realistically.

@jglick jglick requested a review from a team as a code owner June 30, 2021 23:11
@NickLiffen
Copy link

@jglick if you see here:

https://github.com/EliLillyCo/jenkinsdsl/blob/e6ee83976ddb29cd46d28fee63b8b4ccd7c59930/test/src/com/lilly/cirrus/jenkinsdsl/core/BuildAbortionStageSpec.groovy

I think most of these can be deleted, but I would like some tests around how this works if that's okay 👍

@jglick
Copy link
Author

jglick commented Jul 1, 2021

I would like some tests around how this works

Your test system is over my head I am afraid. The actual Pipeline code is covered by jenkinsci/pipeline-milestone-step-plugin#12.

@jglick
Copy link
Author

jglick commented Oct 12, 2021

jenkinsci/workflow-job-plugin#200 has been released; I would recommend that now instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants