-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v3] Blade component #62
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
juliomotol
reviewed
Sep 10, 2020
Just added basic tests and cleaned up after removing the blade directive. <x:sri.script src="/public/js/app.js" />
<!-- <script src="{{ asset("/public/js/app.js") }}" integrity= "..." /> -->
<x:sri.script src="/public/js/app.js" mix />
<!-- <script src="{{ mix("/public/js/app.js") }}" integrity= "..." /> -->
<x:sri.link href="/public/css/app.css" rel="stylesheet" />
<!-- <link href="{{ asset("/public/css/app.css") }} rel="stylesheet" integrity= "..." /> -->
<x:sri.link href="/public/css/app.css" rel="stylesheet" mix />
<!-- <link href="{{ mix("/public/css/app.css") }} rel="stylesheet" integrity= "..." /> --> |
I decided to drop Laravel 7 support. I had to many issues with the tests. I also added a |
Merged
Co-authored-by: Dieter Sting <[email protected]>
Co-authored-by: Dieter Sting <[email protected]>
3fc6c02
to
f7cbc9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I finally found some time to draft a PR for the blade component.
For more details check #57
It's a first draft, but here's what the API could look like. This would simplify the usage of the package.