Move directive initialisation to the boot method #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the conversation in #23 it seems that the
Blade::directive()
usage in theregister()
method isn't initialised. In Laravel 5.8, thefacadeAccessor()
for theBlade
facade now returns the accessor string instead of an instance like in previous versions (see laravel/framework#25497).According to the documentation, using facades in the
register
method isn't recommended as they may not have been defined yet, so they should be used in theboot
method, which occurs after allregister
methods have finished.I've tested this in Laravel 5.5, 5.6 and 5.8. Also, @HDVinnie has tested it on dev servers using Laravel 5.7 and 5.8 as per #23 (comment).
The PHPUnit tests seem to work as expected on Travis and locally, but @Elhebert, please feel free to test this.
Fixes #23