feat(js): dropped RequireJS in favor of ECMAScript modules #14562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdalsem
changed the title
jdalsem
force-pushed
the
6.php83
branch
6 times, most recently
from
6259753 to
79acfdb
Compare
jdalsem
force-pushed
the
6.php83
branch
4 times, most recently
from
617a0fe to
45da82d
Compare
jeabakker
reviewed
Feb 16, 2024
| @@ -29,6 +29,7 @@ class CacheHandler { | |||
| 'js' => 'application/javascript', | |||
| 'json' => 'application/json', | |||
| 'map' => 'application/json', | |||
| 'mjs' => 'application/javascript', | |||
There was a problem hiding this comment.
should be mimetype text/javascript https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/MIME_types/Common_types
jeabakker
approved these changes
Feb 16, 2024
|
@jdalsem @jeabakker 🥇 Wow! What a huge effort. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #14367