Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation wrapper doesn't proxy array access correctly #7017

Closed
mrclay opened this issue Jul 7, 2014 · 1 comment
Closed

Deprecation wrapper doesn't proxy array access correctly #7017

mrclay opened this issue Jul 7, 2014 · 1 comment
Labels
bug engine

Comments

@mrclay
Copy link
Member

mrclay commented Jul 7, 2014

Array access methods on the wrapper don't properly check for array access methods on the wrapped object. Instead they convert to property access.

This causes #6917 because the array access to session fails in twitter_api_get_access_token().
mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Jul 7, 2014
@mrclay
fix(deprecation): the deprecation wrapper correctly handles array access
02e07b8 
When array access is used on the wrapper, the wrapper now checks the wrapped
object for ArrayAccess. If found, it uses that instead of property access.
This also emits deprecation warnings on array access, which were left out
accidentally.

Fixes Elgg#7017
@mrclay mrclay mentioned this issue Jul 7, 2014
Merged
mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Jul 7, 2014
@mrclay
fix(deprecation): the deprecation wrapper correctly handles array access
264fc5f 
When array access is used on the wrapper, the wrapper now checks the wrapped
object for ArrayAccess. If found, it uses that instead of property access.
This also emits deprecation warnings on array access, which were left out
accidentally.

Fixes Elgg#7017, Elgg#6917
@mrclay
Copy link
Member Author

mrclay commented Jul 7, 2014

Fix: #7018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug engine
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mrclay