Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File embedding not working if rich text editor is not used #6160

Closed
jdalsem opened this issue Oct 22, 2013 · 1 comment
Closed

File embedding not working if rich text editor is not used #6160

jdalsem opened this issue Oct 22, 2013 · 1 comment
Milestone
Elgg 1.9.0 Releas...

Comments

@jdalsem
Copy link
Member

jdalsem commented Oct 22, 2013

Disable the CK editor or hide editor and it is not possible to embed content

Issue in Elgg 1.9-dev
@jdalsem
Copy link
Member Author

jdalsem commented Feb 18, 2014

@sembrestels could you take a look at this

sembrestels pushed a commit to sembrestels/Elgg that referenced this issue Feb 21, 2014
fix(embed): file embedding wasn't working for textareas
d3d6abd 
Issue was introduced in 8b358c5 by removing the line that applies the text
change in textarea.

The way to extend javascript from the rich text editor was to extend a view
in js/embed/embed. It has been refactored to the 'embed', 'editor' js hook,
in order to make js/embed/embed convertible to js file. The view extension
has been deprecated.

Text areas and rich text editors manage the insertion diferently. In order
to insert the content in the correct place, we allow rich text editors to
return false inside the hook to stop the insert, and apply it just once.

Fixes Elgg#6160
@sembrestels sembrestels mentioned this issue Feb 21, 2014
Merged
2 tasks
sembrestels pushed a commit to sembrestels/Elgg that referenced this issue Feb 21, 2014
fix(embed): file embedding wasn't working for textareas
4f1ffde 
Issue was introduced in 8b358c5 by removing the line that applies the text
change in textarea.

The way to extend javascript from the rich text editor was to extend a view
in js/embed/embed. It has been refactored to the 'embed', 'editor' js hook,
in order to make js/embed/embed convertible to js file. The view extension
has been deprecated.

Text areas and rich text editors manage the insertion diferently. In order
to insert the content in the correct place, we allow rich text editors to
return false inside the hook to stop the insert, and apply it just once.

Fixes Elgg#6160
sembrestels pushed a commit to sembrestels/Elgg that referenced this issue Feb 28, 2014
fix(embed): file embedding wasn't working for textareas
8f57d19 
Issue was introduced in 8b358c5 by removing the line that applies the text
change in textarea.

The way to extend javascript from the rich text editor was to extend a view
in js/embed/embed. It has been refactored to the 'embed', 'editor' js hook,
in order to make js/embed/embed convertible to js file. The view extension
has been deprecated.

Text areas and rich text editors manage the insertion diferently. In order
to insert the content in the correct place, we allow rich text editors to
return false inside the hook to stop the insert, and apply it just once.

Fixes Elgg#6160
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
Elgg 1.9.0 Release Candidate
Development

No branches or pull requests
2 participants
@ewinslow @jdalsem