Add ERROR logging prefix and sort the prefixes alphabetically #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks for the catch! |
Quentin-Anthony
approved these changes
Oct 17, 2024
jahatef
pushed a commit
that referenced
this pull request
Nov 5, 2024
* Add ERROR logging prefix and sort alphabetically * fix comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to run
./deepy.py train.py ...I got the following error:I tracked this down and found that we have a number of formatted logging prefixes with colors, but
ERRORwas missing. I added that (with the color red, same as forFAIL), sorted the prefixes alphabetically, and grouped them a bit for clearer organization. Tested and got an actual error message after the change.