Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gomod: Update to lnd v0.15.2-beta #142

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

nepet
Copy link
Contributor

@nepet nepet commented Oct 10, 2022

We need a fast update to the newest lnd version as there was a security issue detected.
lightningnetwork/lnd#7002

As the bug was part of the btcd dependencies the fix applied in btcsuite/btcd#1896 brings a long tail of dependency updates.

This commit updates the dependencies and adapts for all changes that are introduced by this new dependencies.

Please test this on bitcoin as well as on liquid-bitcoin as there have been some changes in the dependencies go-elements and btcd

We need a fast update to the newest lnd version as there was a
security issue detected.
lightningnetwork/lnd#7002

As the bug was part of the btcd dependencies the fix applied in
btcsuite/btcd#1896 brings a long tail
of dependency updates.

This commit updates the dependencies and adapts for all changes
that are introduced by this new dependencies.
@wtogami
Copy link
Contributor

wtogami commented Oct 11, 2022

# git checkout origin/pr/142
HEAD is now at d88023c gomod: Update to lnd v0.15.2-beta
# make cln-release
# PeerSwap CLN builds
rm -f peerswap-plugin
rm -f out/peerswap-plugin
# peerswap-plugin binary is not installed in GOPATH because it must be called by full pathname as a CLN plugin.
# You may choose to install it to any location you wish.
go build -o peerswap-plugin -ldflags "-X main.GitCommit=d88023caabb3e45bf80f02016b3c84794c38c0d7" ./cmd/peerswap-plugin/main.go


go: github.com/lightningnetwork/[email protected] requires
	github.com/juju/[email protected] requires
	github.com/juju/utils/[email protected] requires
	github.com/juju/[email protected] requires
	github.com/juju/utils/[email protected] requires
	launchpad.net/[email protected]: unrecognized import path "launchpad.net/gocheck": GOVCS disallows using bzr for public launchpad.net/gocheck; see 'go help vcs'
make: *** [Makefile:146: cln-release] Error 1

Copy link

@pablof7z pablof7z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK

@wtogami
Copy link
Contributor

wtogami commented Oct 13, 2022

https://twitter.com/wtogami/status/1580420954597240832
Figured out the build error. It requires GOVCS='*:all' and the bzr tool. LND should move to pure git deps. Those upstream repos had moved to git long ago.

The build problems were not peerswap's fault.

ACK

@nepet nepet merged commit afb2976 into ElementsProject:master Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants