Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin args passed as strings regardless of type designation #3577

Closed
ProofOfKeags opened this issue Mar 7, 2020 · 0 comments
Closed

Plugin args passed as strings regardless of type designation #3577

ProofOfKeags opened this issue Mar 7, 2020 · 0 comments
Assignees
@niftynei
Labels
plugin

Comments

@ProofOfKeags
Copy link

The manifest option types specify that options can be either "string", "int", or "bool". The expectation here would be that for "int" and "bool" arguments, they would be passed into the init call, unquoted.

Example (Expected):
--test-arg=1000 --> "test-arg": 1000

Example (Actual):
--test-arg=1000 --> "test-arg": "1000"

This is true, even in the case of manifest supplied defaults.
@niftynei niftynei added the plugin label Mar 7, 2020
@niftynei niftynei self-assigned this Mar 7, 2020
niftynei added a commit to niftynei/lightning that referenced this issue Mar 8, 2020
@niftynei
plugins: pass back opts as indicated type. fixes ElementsProject#3577
a8e9324 
Changelog-Fixed: Plugins: if an option has a type int or bool, return the option as that type to the plugin's init
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niftynei niftynei

Labels
plugin
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@niftynei @ProofOfKeags