Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.18 backport] Make issuance fail for invalid addresses #867

Merged
merged 2 commits into from
Apr 16, 2020
Merged

[0.18 backport] Make issuance fail for invalid addresses #867

merged 2 commits into from
Apr 16, 2020

Conversation

stevenroose
Copy link
Member

@stevenroose stevenroose commented Apr 16, 2020 •
edited
Loading

Backport of #861.

@stevenroose stevenroose mentioned this pull request Apr 16, 2020
Merged
@stevenroose
Make issuance fail for invalid addresses
21b3913 
Without his change, invalid addresses are converted into fee outputs.
@stevenroose
Add test to make sure issuances to wrong addresses fail
8e5893e
@gwillen
Copy link
Contributor

gwillen commented Apr 16, 2020 •
edited
Loading

Diff looks the same as the backported MR:

bunneh:elements gwillen$ git range-diff upstream/pr/867^^..upstream/pr/867 upstream/pr/861^^..upstream/pr/861
1:  21b3913a7 = 1:  1b8bf85d8 Make issuance fail for invalid addresses
2:  8e5893ecb = 2:  425691623 Add test to make sure issuances to wrong addresses fail

(I guess that's a utACK? I'm never clear on how reviewing for backports is meant to work.)

@stevenroose
Copy link
Member Author

Epic command!

@stevenroose stevenroose merged commit 292f9f5 into ElementsProject:elements-0.18 Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
0.18
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevenroose @gwillen